Disable Bun hot reloading #1144
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @vorburger, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request addresses the broken hot reloading issue with Bun, as identified in issue #1143. The changes involve updating the web/README.md file to reflect the current status of Bun's hot reloading feature and removing a related to-do item from web/ToDo.md.
Highlights
- Documentation Update: The
web/README.mdfile is updated to indicate that Bun should hot-reload on changes, but also notes that it's currently broken and links to issue Bun Dev Server CSS reload is broken #1143. - To-Do Item Removal: A to-do item about auto-rebuilding and reloading on file change is removed from
web/ToDo.md.
Changelog
- web/README.md
- Added a note about Bun's hot reloading feature.
- Added a disclaimer that hot reloading is currently broken and links to issue Bun Dev Server CSS reload is broken #1143.
- web/ToDo.md
- Removed the to-do item related to auto-rebuilding and reloading on file change.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
The hot reload's a fickle friend,
Sometimes it works, sometimes it's the end.
We chase the fix, with code in hand,
To make our dev lives oh so grand.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request addresses the broken hot reloading issue with Bun. It involves updating the README to reflect the current status and removing a related item from the ToDo list. The changes are straightforward and seem appropriate for the described issue.
Summary of Findings
- README Update: The README has been updated to reflect the current status of Bun hot reloading and link to the relevant issue.
- ToDo List Update: The ToDo list has been updated by removing the item related to auto-rebuilding and reloading in the browser.
Merge Readiness
The changes are relatively small and focused on documentation. Given the context of the linked issue, the updates seem reasonable. I am unable to approve the pull request, and recommend that others review and approve this code before merging.
vorburger
force-pushed
the
bun-hot-reload
branch
from
3383c55 to
3b6a99f
Compare
Relates to
(and is pending)#1143...